Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic swap feature not showing received funds as a transaction #292

Closed
peepohns opened this issue Jan 22, 2021 · 4 comments · Fixed by #296
Closed

Atomic swap feature not showing received funds as a transaction #292

peepohns opened this issue Jan 22, 2021 · 4 comments · Fixed by #296

Comments

@peepohns
Copy link

I just did an atomic swap as a seller and although I did receive the HNS (my wallet balance updated) I do not see it as a separate received transaction in the wallet. I only see the "Finalized" transaction. I checked with another seller that used the feature and the same happened to him.
Capture

@pinheadmz
Copy link
Contributor

This is good feedback. The atomic swap transaction is a non-standard construction that does two things in one TX: It's a FINALIZE and a payment.

The Bob UI is designed to only show one "thing" per transaction, so it fits nicely on one line. If you used the API to send a TX with two outputs and pay two people at once for example, I'm pretty sure the UI would just display the first payment. Notice that this UI function also hides the change output from the user etc, so it's just a nice simplification.

It's not super easy for Bob to "guess" what single label to use for each TX. The logic is here and could probably be improved.

@peepohns
Copy link
Author

Gotcha! I saw your atomic swap video and the transaction showed so I thought it was a bug of some sort. Appreciate the clarification!
dd

@pinheadmz
Copy link
Contributor

Ohhhhh good catch! Yeah I am running a slightly different / older version of Bob here too.

@peepohns
Copy link
Author

Yup! I think it can be confusing for some new users if they don't see the deposit transaction separately (especially if they transact a lot). I wasn't sure at first if I got it as it was a small amount but checked by peaking at the txid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants