Using sql helper in promise chains causes unexpected preventAwait errors

[icopp]

Here's a simple example:

import { sql } from 'kysely'

// a plain promise for the example, but this could be a value determined inside a transaction
// or as part of some other promise chain
const someTimestampValue = Promise.resolve(true).then(
  (value) => value
    ? sql<string>`'infinity'::timestamptz`
    : sql<string>`'-infinity'::timestamptz`
)

This results in a raised error:

Error: don't await RawBuilder instances directly. To execute the query you need to call `execute`

This is non-obvious behavior for a tag function, where I think the expected behavior here should be to act much more like a generic object (e.g. const a = b and const a = await b should have effectively the same behavior).

[koskimas]

If we remove the check, we get a new issue: especially people coming from knex will be confused when

await sql`some sql`

doesn't execute the query. Since you are the first one to bring this up, I'm assuming that'd be a bigger problem.

You can wrap the sql snippets in objects as a workaround

const someTimestampValue = Promise.resolve(true).then(
  (value) => value
    ? { sql: sql<string>`'infinity'::timestamptz` }
    : { sql: sql<string>`'-infinity'::timestamptz` }
)

[igalklebanov]

This'll be resolved in v0.28 following merge of #1160.