Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Remove parameter value from pack and get_size #196

Open
beraldoleal opened this issue Oct 6, 2016 · 3 comments
Open

Remove parameter value from pack and get_size #196

beraldoleal opened this issue Oct 6, 2016 · 3 comments

Comments

@beraldoleal
Copy link
Member

In an ideal world is not necessary to do object.pack(another_object) or obj.get_size(something).

@erickvermot
Copy link
Contributor

If the 'work_or_pass' logic is accepted a4c1f05, removing the 'value' parameter becomes very natural. (there are almost no calls to pack with a value parameter left).

If a different value needs to be packed, it should be done initializing a new instance with the value, and then calling the corresponding pack function.

@cemsbr
Copy link
Contributor

cemsbr commented Jul 18, 2017

@erickvermot, if you had to do it based on master branch, without any other pending PR, what would be the simplest solution?

@erickvermot
Copy link
Contributor

I'd do the changes in a4c1f05, without the need to implement the work_or_pass function.

It is a very simple solution.
Why, this commit is not planned to be accepted?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants