Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4L performance divide by two when starting stream #128

Closed
OlivierLDff opened this issue Jun 15, 2023 · 1 comment
Closed

V4L performance divide by two when starting stream #128

OlivierLDff opened this issue Jun 15, 2023 · 1 comment

Comments

@OlivierLDff
Copy link

PR #121 introduce a performance regression. When calling stream.start, frame rate is divided by 2. I have no idea why, I'm currently investigating.
@OlivierLDff
Copy link
Author

I found the catch:

  • Calling stream.next push internal buffers to v4l then call stream.start. By default with new buffer count is 4.
  • Add Raspberry Pi support #121 directly call stream.start, without setting any buffer. This result in v4l only having 1 buffer (I guess), so because there is no double buffer (or more), 1 frame out of two is skipped.

My suggestion is that nokhwa shouldn't call stream.start, or put it behing a feature flag. So by default performance are normal. On raspberry PI performance can be downgraded in order not to crash.

@OlivierLDff OlivierLDff mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OlivierLDff