Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad code path in --random: can't specify directory on command line #85

Closed
daf opened this issue Nov 19, 2016 · 0 comments
Closed

Bad code path in --random: can't specify directory on command line #85

daf opened this issue Nov 19, 2016 · 0 comments
Assignees
Milestone

Comments

@daf
Copy link
Member

daf commented Nov 19, 2016

Noticed in warnings from #84:

main.cc: In function ‘int set_bg_once(Config*, SetBG*, Glib::ustring, int, SetBG::SetMode, bool, Gdk::Color, bool)’:
main.cc:49:40: warning: left operand of comma operator is a reference, not call, to function ‘Glib::file_test’ [-Waddress]
             if (Glib::file_test, Glib::FILE_TEST_IS_DIR) {
                                        ^
main.cc:49:40: warning: left operand of comma operator has no effect [-Wunused-value]

This is certainly not working properly. Code is main.cc:49

@daf daf self-assigned this Nov 19, 2016
@daf daf added this to the 1.6.x milestone Nov 19, 2016
@daf daf closed this as completed in 2d1ad3e Nov 19, 2016
@daf daf modified the milestones: 1.6.x, 1.6.1 Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant