Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please clearly state the MSRV in the README and documentation and use the "rust-version" flag. #227

Closed
iddm opened this issue Jan 15, 2024 · 2 comments

Comments

@iddm
Copy link

iddm commented Jan 15, 2024

This really, really helps to figure out what's wrong when cargo doesn't want to find the appropriate package on older (incompatible) rust versions.

@la10736
Copy link
Owner

la10736 commented Jan 15, 2024

You're right.
I'll try to address it ASAP.... but I don't know how to compute it. Is there any tools to do it?

@iddm
Copy link
Author

iddm commented Jan 15, 2024

Usually I figure it during the development lifecycle: one of the dependencies no longer builds after an update and requires a new version, or I need a new version from the Rust compiler myself and so need to bump it. Retroactively, as in this case with rstest, I think only trial and error will work. I updated from 0.13 to 0.18 and I can't build with 1.56 any longer. So something in between should work, I guess. If I figure it out earlier than you, I'll post it here or create a PR.

@la10736 la10736 closed this as completed in 767d478 Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants