Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding a wasm-bindgen feature #260

Open
themighty1 opened this issue Jun 10, 2024 · 2 comments
Open

consider adding a wasm-bindgen feature #260

themighty1 opened this issue Jun 10, 2024 · 2 comments

Comments

@themighty1
Copy link

Hi, I have a test which uses rstest's
#[timeout(Duration::from_millis(10000))]

When compiling it with wasm-pack test --release --chrome and running it in the browser, I was getting errors.

I was able to get rid of the errors by having these deps

[dev-dependencies]
rstest = { version = "0.21", features = ["async-timeout"] }
# force `rstest` to depend on `futures-timer` with a wasm-compatible feature
futures-timer = { version = "*", features = ["wasm-bindgen"] }

Maybe rstest could itself have a wasm-bindgen feature which enables the wasm-bindgen feature of futures-timer?

@la10736
Copy link
Owner

la10736 commented Jun 10, 2024

Ok, it seams fine.

Can you provide a minimum example to reproduce it?

@SleeplessOne1917
Copy link

Bumping this. I also could really use things like test cases and fixtures and the like with wasm-bindgen-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants