Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxi(FR-423): Unkown image error in Image list's control modal #3064

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Jan 21, 2025

resolves #3063 (FR-423)

Updates image fragment handling in ManageAppsModal and ManageImageResourceLimitModal to support the new namespace field introduced in version 24.12.0, while maintaining backwards compatibility with the deprecated name field.

Checklist:

  • Minimum required manager version: 24.12.0
  • Minimum requirements to check during review:
    • Verify image management works with both old and new image naming formats
    • Confirm resource limits and app management functions correctly with namespaced images

@github-actions github-actions bot added the size:M 30~100 LoC label Jan 21, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby requested a review from ironAiken2 January 21, 2025 09:18
@yomybaby yomybaby marked this pull request as ready for review January 21, 2025 09:18
@yomybaby yomybaby changed the title fxi(FR-342): Unkown image error in Image list's control modal fxi(FR-432): Unkown image error in Image list's control modal Jan 21, 2025
@yomybaby yomybaby changed the title fxi(FR-432): Unkown image error in Image list's control modal fxi(FR-423): Unkown image error in Image list's control modal Jan 21, 2025
@yomybaby yomybaby force-pushed the fix/image-mutation-bug-related-to-namespace branch from 6e770cc to e823b5d Compare January 21, 2025 09:30
Copy link

github-actions bot commented Jan 21, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.91% 398/8112
🔴 Branches 4.24% 239/5633
🔴 Functions 2.95% 78/2641
🔴 Lines 4.83% 383/7937

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 49288d1

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Jan 23, 2025

Merge activity

resolves #3063 (FR-423)

Updates image fragment handling in ManageAppsModal and ManageImageResourceLimitModal to support the new namespace field introduced in version 24.12.0, while maintaining backwards compatibility with the deprecated name field.

**Checklist:**
- [x] Minimum required manager version: 24.12.0
- [x] Minimum requirements to check during review:
  - Verify image management works with both old and new image naming formats
  - Confirm resource limits and app management functions correctly with namespaced images
@yomybaby yomybaby force-pushed the fix/image-mutation-bug-related-to-namespace branch from e823b5d to 49288d1 Compare January 23, 2025 08:15
@graphite-app graphite-app bot merged commit 49288d1 into main Jan 23, 2025
6 checks passed
@graphite-app graphite-app bot deleted the fix/image-mutation-bug-related-to-namespace branch January 23, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unkown image error in Image list's control modal
2 participants