Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the status_history column in the kernels and sessions tables to list. #3200

Open
jopemachine opened this issue Dec 5, 2024 · 0 comments · May be fixed by #3201
Open

Change the status_history column in the kernels and sessions tables to list. #3200

jopemachine opened this issue Dec 5, 2024 · 0 comments · May be fixed by #3201
Assignees
Labels
comp:client Related to Client component comp:manager Related to Manager component type:feature Add new features type:refactor Refactor codes or add tests.
Milestone

Comments

@jopemachine
Copy link
Member

jopemachine commented Dec 5, 2024

The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.

Let’s change the data structure to a List to ensure that previous information is not lost.

Details

  • For compatibility with the existing API, the status_history field in compute_session GQL will remain unchanged. Instead, let’s deprecate status_history and add a new field called status_history_log.

Discussion

@fregataa I have a few questions regarding the task.

  • Should we retain the status_history legacy field in the new API (compute_session_node) as well? Personally, I think it might be better to remove the deprecated status_history and keep only status_history_log.

  • Unlike compute_session, the compute_container GQL does not have a status_history field. Is there a specific reason why compute_container does not have a status_history field? If not, I think it would be better to add status_history_log.

@jopemachine jopemachine added this to the 24.12 milestone Dec 5, 2024
@jopemachine jopemachine self-assigned this Dec 5, 2024
@jopemachine jopemachine added type:feature Add new features type:refactor Refactor codes or add tests. comp:manager Related to Manager component comp:client Related to Client component labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:client Related to Client component comp:manager Related to Manager component type:feature Add new features type:refactor Refactor codes or add tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant