Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying scaling groups in the modify_keypair mutation #3270

Open
ironAiken2 opened this issue Dec 19, 2024 · 0 comments
Open

Allow modifying scaling groups in the modify_keypair mutation #3270

ironAiken2 opened this issue Dec 19, 2024 · 0 comments

Comments

@ironAiken2
Copy link

ironAiken2 commented Dec 19, 2024

Main idea

teams

Currently, to set a scaling_group for a keypair, we need to use the associate_scaling_groups_with_keypair mutation in addition to the modify_keypair mutation. This can have unexpected side effects and is not a good practice in terms of error handling.

To address these issues, it is proposed to modify the modify_keypair mutation to include the ability to modify scaling_groups. This change will streamline the process and improve the overall functionality and reliability of the system.

Anything else?

Currently, if scaling_groups are assigned to the Keypair, it cannot be reassigned to 'associate_scaling_groups_with_keypair' mutation. For reassignment, we must deallocate through 'disassociate_scaling_groups_with_keypair' mutation and try again with 'associate_scaling_groups_with_keypair' mutation.

And neither both association nor disassociation mutations work with scaling_groups argument of empty strings or empty arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant