New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the VFolder decorator to perform an early cut for unintended cases #3463

Closed

HyeockJinKim opened this issue Jan 15, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3465

Assignees

Collaborator

HyeockJinKim commented Jan 15, 2025 •

edited

Loading

Summary

The VFolder handler should only process a single VFolder, and if multiple VFolders with the same name exist, it should trigger an error.

Steps to Reproduce

When there are multiple VFolders with the same name, the system returns the value for the first successful request.
The behavior of which action will be executed is not deterministic.

Expected Behavior

When there are multiple VFolders with the same name, an error is triggered.
- In this situation, if the client wants to delete vfolder, they must request the VFolder ID for each one.

Actual Behavior

If one of the VFolders with the same name is requested to be deleted, an unintended VFolder may be deleted.

HyeockJinKim self-assigned this

HyeockJinKim mentioned this issue

fix(BA-517): Raise exception if multiple VFolders exist in decorator #3465

Merged

7 tasks

HyeockJinKim closed this as completed in #3465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment