Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add the pointer style for CopyText #1404

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

imyuanx
Copy link
Contributor

@imyuanx imyuanx commented Jul 14, 2023

image

Copy link
Contributor

@0fatal 0fatal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "cursor-pointer" to the icon, don't add to CopyText directly

@imyuanx
Copy link
Contributor Author

imyuanx commented Jul 14, 2023

add "cursor-pointer" to the icon, don't add to CopyText directly

I don't think we just to add cursor-pointer to icon, because the entire CopyText is clickable.

If we just add cursor-pointer to the icon then customize children of <CopyText />, you can see that, It's not user-friendly.

image

@0fatal
Copy link
Contributor

0fatal commented Jul 17, 2023

add "cursor-pointer" to the icon, don't add to CopyText directly

I don't think we just to add cursor-pointer to icon, because the entire CopyText is clickable.

If we just add cursor-pointer to the icon then customize children of <CopyText />, you can see that, It's not user-friendly.

image

Trying to keep components single duty and not doing too many things. Also, have you tested all the places where CopyText is used?

By the way, className = "cursor-pointer" is not quite right, try clsx("cursor-pointer", className)

@imyuanx
Copy link
Contributor Author

imyuanx commented Jul 19, 2023

Hello, there are some changes here and I tested almost all of the CopyText, I removes cursor-pointer from the all CopyText classname.

@imyuanx imyuanx requested a review from 0fatal July 19, 2023 02:03
@0fatal 0fatal merged commit d261113 into labring:main Jul 19, 2023
@imyuanx imyuanx deleted the feat-pointer-style branch July 19, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants