fix(server): fixed the error of repeatedly deleting website routes #957
Conversation
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -194,7 +194,6 @@ export class WebsiteTaskService { | |||
| // delete website route if exists | |||
| const route = await this.apisixService.getRoute(region, site._id.toString()) | |||
| if (route) { | |||
| await this.apisixService.deleteWebsiteRoute(region, site) | |||
| const res = await this.apisixService.deleteWebsiteRoute(region, site) | |||
| this.logger.log(`delete website route: ${res?.key}`) | |||
| this.logger.debug('delete website route', res) | |||
There was a problem hiding this comment.
by looking at the code.
The code is trying to delete a website route in the ApisixService. The code first checks if the route exists, and if it does, it attempts to delete it using the deleteWebsiteRoute method. The result of this operation is then logged.
It looks like there is a bug risk in this code. The code tries to delete the route even if it doesn't exist. This could lead to errors or unexpected behavior. To fix this, we can add a check to make sure the route exists before attempting to delete it.
In addition, it looks like the code is trying to log the result of the deletion operation. However, the code is not properly checking if the result is successful or not. To make sure that only successful deletions are logged, we can add a check to the logging code to ensure the result was successful before logging it.
No description provided.