Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between API and GUI when handling zip groups #60

Open
philipstarkey opened this issue Jun 19, 2018 · 0 comments
Open

Difference between API and GUI when handling zip groups #60

philipstarkey opened this issue Jun 19, 2018 · 0 comments
Labels
bug Something isn't working major

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


I believe the API won't automatically detect zip groups when compiling a sequence of shots. I'm not sure if this makes sense or not.

On the one hand, we could argue that if you are using the API, then the globals file should explicitly specify the expansion column correctly for every global and not expect the runmanager API to work things out.

On the other hand, this is a real PITA if you just want programmatic control over compilation of shots, but otherwise identical behaviour to the GUI.

The solution is probably supporting both ways. Anyway, the missing thing is the fact that guess_expansion_modes exists in the GUI code, not in the API code for runmanager, and that this needs to be iteratively called until the expansion types settle to a steady state (see preparse_globals in the GUI code.

@philipstarkey philipstarkey added major bug Something isn't working labels Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant