New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewTracedRequest - nil Body #44

Closed

Dredouane opened this issue Jan 7, 2021 · 3 comments

Dredouane commented Jan 7, 2021

echo-contrib/jaegertracing/jaegertracing.go

Line 240 in fd04525

req, err := http.NewRequest(method, url, nil)

POST requests are sent with a nil body? the body param is not used or I'm missing something?
Thanks

Contributor

arun0009 commented Apr 6, 2021

@carlosedp I think this is a bug? @Dredouane feel free to pass the body to the line you referenced and open a PR maybe?

Contributor

m1x0n commented Jun 30, 2022

This bit should fix #71

Contributor

m1x0n commented Jan 4, 2023

Fixed in https://github.com/labstack/echo-contrib/releases/tag/v0.13.1

Dredouane closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment