Remote LabRecorder: Variable 'offset' is being used without being initialized

[agricolab]

I was attempting to record EEG data from BrainVisionRecorder, calling LabRecorderCLI.exe type='EEG'.
The console printed

Found BrainVision RDA@DESKTOP-79JUEJU matching 'type='EEG''
Starting the recording, press Enter to quit
Opened the stream BrainVision RDA.
Received header for stream BrainVision RDA.
Started data collection for stream BrainVision RDA.
Timeout in time correction query for stream 1

then it threw

This error was reproducible, although the same command run flawless a few days before on another machine. The error occurs also if i start the recording via the remote LabRecorderGUI. Note that the old LabRecorder version 1.13 records without error message, but when i attempt to load the data, it throws an LinAlgError("Matrix is not positive definite"). So both errors seems to be related to the clock-offset issue, but are throwing different errors. After a reboot, the error did no longer occur.

[tstenner]

I remember fixing the clock offsets bug as if it was yesterday, mostly because it was yesterday. I haven't had time to upload the new binaries, but in some very rare circumstances the clock synchronization could time out nevertheless so this should be fixed.

[cboulay]

This error can still happen if the in->time_correction(2) call fails.
In this block of code, shouldn't the rest of the code that depends on now and offset be inside the try block?

[tstenner]

In this block of code, shouldn't the rest of the code that depends on now and offset be inside the try block?

Yes and I don't know why it isn't.