-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find more liblsl variants #18
Conversation
…r as well as the system search path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the small change to move the if 'PYLSL_LIB'
block to the top of the function. Other than that it looks good.
Have you fixed the CI builds since this PR? |
1c9ab32
to
7ac55cf
Compare
The CI builds just fine now, I've also switched from full builds to the prebuilt binaries fron sccn/liblsl releases so the build is a lot faster now (6m->21s). I'm not sure if the tag is correct ( |
I've never had to do anything to specify the tag because |
I think you can just do |
b342fe2
to
c2c7261
Compare
I removed the |
I checked the resulting package; auditwheel is happy:
Also, both Python 2.7, 3.4 and 3.7 from the manylinux2010 image can install the wheel produced by the CI and run the examples so I think we could merge it. |
And I've added the manylinux1 builds. |
29a15f9
to
01ca15e
Compare
…etter local reproducibility
This PR searches a bit harder for liblsl, namely
liblsl
with or without debug suffices (-debug
), bitness suffices (32
,64
depending on the platform) and in thepylsl.py
directory and the default system search path.Also, users can set the
PYLSL_LIB
environment variable (see #13) to load a specific library.