Switch away from dunder to LABTHINGS_EXTENSIONS

labthings · Nov 30, 2020 · 3b6e9af · 3b6e9af
1 parent db5677a
commit 3b6e9af
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/src/labthings/extensions.py b/src/labthings/extensions.py
@@ -262,11 +262,25 @@ def find_extensions_in_file(extension_path: str, module_name="extensions") -> li
         )
         return []
     else:
-        if hasattr(mod, "__extensions__"):
+        if hasattr(mod, "LABTHINGS_EXTENSIONS"):
+            return [
+                ext_obj
+                for ext_obj in getattr(mod, "LABTHINGS_EXTENSIONS")
+                if isinstance(ext_obj, BaseExtension)
+            ]
+        elif hasattr(mod, "__extensions__"):
+            logging.warning(
+                "Explicit extension list using the __extensions__ global is deprecated.",
+                "Please use LABTHINGS_EXTENSIONS instead.",
+            )
             return [
                 getattr(mod, ext_name) for ext_name in getattr(mod, "__extensions__")
             ]
         else:
+            logging.warning(
+                "No LTX_MANIFEST found for %s. Searching for implicit extension objects.",
+                extension_path,
+            )
             return find_instances_in_module(mod, BaseExtension)