Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in NumPy 1.19.0 #198

Closed
paulmelnikow opened this issue Jun 29, 2020 · 1 comment · May be fixed by #202
Closed

Fix regression in NumPy 1.19.0 #198

paulmelnikow opened this issue Jun 29, 2020 · 1 comment · May be fixed by #202

Comments

@paulmelnikow
Copy link
Member

@jlevin
Copy link
Contributor

jlevin commented Nov 16, 2022

We have not been able to reproduce this issue locally on MacOS.

To reproduce this issue in CI:

import numpy as np
import vg
from polliwog import Plane

point_on_plane = np.array([1.0, 2.0, 3.0])
plane_normal = vg.normalize(np.array([3.0, 4.0, 5.0]))
plane = Plane(point_on_plane=point_on_plane, unit_normal=plane_normal)

print(plane.sign(point_on_plane))
print(plane.sign(np.array([point_on_plane])))

Both values are expected to be zero, but the last value is returned as 1. This bug is causing the test to fail

This was fixed in BREAKING CHANGE: Change Plane constructor (#303)

@jlevin jlevin closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants