Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admission-controller] Does not respect .Values.cert.secret_name #115

Closed
jstewart612 opened this issue Oct 19, 2022 · 1 comment · May be fixed by #116
Closed

[admission-controller] Does not respect .Values.cert.secret_name #115

jstewart612 opened this issue Oct 19, 2022 · 1 comment · May be fixed by #116

Comments

@jstewart612
Copy link

jstewart612 commented Oct 19, 2022 •
edited
Loading

The Secret gets created no matter what. This value in the values.yaml file is respected in the Deployment object, but a pointless Secret resource is made. I will be submitting a PR that fixes this oversight.
@jstewart612 jstewart612 mentioned this issue Oct 19, 2022
Open
@michael-zhou-lw
Copy link
Contributor

Thanks for raising this issue @jstewart612, this has been added in #148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.1.15 admission-controller Helm Charts jstewart612/lacework-helm-charts
2 participants
@jstewart612 @michael-zhou-lw