Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about bogus timeout options #1185

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Warn about bogus timeout options #1185

merged 1 commit into from
Feb 22, 2017

Conversation

kornelski
Copy link
Contributor

.timeout({request:1000}) is an easy mistake to make.

@focusaurus focusaurus merged commit 52bd175 into master Feb 22, 2017
@focusaurus focusaurus deleted the timewarner branch February 22, 2017 17:08
kornelski added a commit that referenced this pull request Mar 5, 2017
* origin/master: (32 commits)
  Progress event doc
  v3.5.0
  Add errno to distinguish between request timeout and body download timeout (#1184)
  Warn about bogus timeout options (#1185)
  3.4.4
  Treat videos like images
  Avoid renaming module
  3.4.3
  3.4.3
  Add node client support for bearer token authentication
  Add client support for bearer token authentication
  Fixed being able to define own parsers when their mime type starts with text/
  conditional withCredentials
  3.4.2
  Updated dependencies
  Use formData.on instead of .once
  Ignore attach(,null)
  3.4.1
  Simplify check
  Dedupe query string append
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants