-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How I can update for formidable to v3. #833
Comments
Formidable is added from the "Superagent" dependency, It looks like they are updating that soon: |
The new version of superagent was just published btw |
Hi! Eagerly awaiting the new version. |
We're going to do a major bump here too shortly. Working on it now. v9.0.0 of superagent was just released by us. Consider supporting us at https://forwardemail.net |
Looks like there's a bug after version bumping, haven't got to the bottom of it yet. If anyone wants to help debug please do: ❯ npm test
> supertest@6.3.4 pretest
> npm run lint --if-present
> supertest@6.3.4 lint
> eslint lib/**/*.js test/**/*.js index.js
> supertest@6.3.4 test
> nyc --reporter=html --reporter=text mocha --exit --require should --reporter spec --check-leaks
Exception during run: TypeError: Cannot read properties of undefined (reading 'push')
at Agent.<computed> [as set] (/Users/user/Projects/supertest/node_modules/.pnpm/superagent@9.0.1/node_modules/superagent/lib/agent-base.js:20:20)
at Suite.<anonymous> (/Users/user/Projects/supertest/test/supertest.js:952:6)
at Object.create (/Users/user/Projects/supertest/node_modules/.pnpm/mocha@10.4.0/node_modules/mocha/lib/interfaces/common.js:148:19)
at context.describe.context.context (/Users/user/Projects/supertest/node_modules/.pnpm/mocha@10.4.0/node_modules/mocha/lib/interfaces/bdd.js:42:27)
at Object.<anonymous> (/Users/user/Projects/supertest/test/supertest.js:949:1)
at Module._compile (node:internal/modules/cjs/loader:1254:14)
at Module.replacementCompile (/Users/user/Projects/supertest/node_modules/.pnpm/append-transform@2.0.0/node_modules/append-transform/index.js:60:13)
at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
at Object.<anonymous> (/Users/user/Projects/supertest/node_modules/.pnpm/append-transform@2.0.0/node_modules/append-transform/index.js:64:4)
at Module.load (node:internal/modules/cjs/loader:1117:32)
at Module._load (node:internal/modules/cjs/loader:958:12)
at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
---------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------|---------|----------|---------|---------|-------------------
All files | 20.58 | 4.8 | 8.69 | 21.11 |
supertest | 37.5 | 0 | 0 | 37.5 |
index.js | 37.5 | 0 | 0 | 37.5 | 26-54
supertest/lib | 17.8 | 5.26 | 10 | 18.24 |
agent.js | 55.55 | 38.46 | 50 | 54.28 | 34-39,55-56,62-77
test.js | 5.45 | 0 | 0 | 5.88 | 26-339
---------------|---------|----------|---------|---------|------------------- If you want to fork / clone / pull latest commit of this repo, I pushed the version bump and it's broken now |
i noticed the version wasn't updated properly. i see this in the npm list tree
|
They still haven't released the new major version. |
@titanism I managed to fix this: |
v7.0.0 released to npm https://github.com/ladjs/supertest/releases/tag/v7.0.0 |
No description provided.
The text was updated successfully, but these errors were encountered: