Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attributes and Schedules to People #1043

Open
ed-p-may opened this issue Oct 13, 2024 · 0 comments
Open

Add Attributes and Schedules to People #1043

ed-p-may opened this issue Oct 13, 2024 · 0 comments

Comments

@ed-p-may
Copy link
Contributor

Hi @chriswmackey

I would like to ask it we can add some additional attributes to the Honeybee-Energy People object?

In order to comply with the new Phius REVIVE standard, they are asking us to set a few specific parameters to these objects for when we do OS simulations. Specifically they are asking for People in the simulations to be able to set:

  • Carbon-Dioxide Generation Rate (default=3.82e-08)
  • Thermal Comfort Model (default='Pierce')
  • Clothing Insulation Schedule
  • Air Velocity Schedule
  • Work Efficiency Schedule

Screenshot 2024-10-13 at 2 41 09 PM

The intent behind adding these attributes is to enable the output of SET temperature (specifically, the "Zone Thermal Comfort Pierce Model Standard Effective Temperature" output variable) from the OSM simulaiton, which they use to verify winter-time thermal resiliency (to certify to their new program, we must show that the total SET degree-hours below 54°F are < 216hrs)


I'd be happy to put together a PR with this change if you would be ok with this addition? My initial thought is that these do not need to be exposed to the normal user or included in the normal Grasshopper object, and that they can be None in all 'normal' cases - but that they are available for us to add to internally for these new REVIVE calculations.

However If you think there is a better way of enabling these changes without modifying the HBE-People class I can certainly try another method? I originally began by sub-classing the HBE-People class and just adding these new attributes myself - but when the object is serialized/de-serialized as part of the to-osm workflow, all that subclass data gets lost since it just de-serialized as a normal HBE-People, so that didn't seem to work.

@ed-p-may

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant