Commit 39d028e
Fix flaky ProgressContantsTest.testKeepOneProperty race condition
The testKeepOneProperty test was failing randomly due to timing issues
when multiple jobs with KEEPONE_PROPERTY finish simultaneously.
Changes:
- Replace fixed 500ms wait with condition-based waiting that ensures
all jobs have actually started (job.inProgress is true)
- Add explicit processEvents() calls after jobs complete and after
marker job appears to ensure all UI event processing is complete
- Increase timeout from 500ms to 3000ms for job startup check
This eliminates the race condition by:
1. Ensuring all jobs are running before signaling them to finish
2. Ensuring job completion events are processed before checking state
3. Ensuring KEEPONE cleanup logic completes before final assertion
Tested with 10 consecutive runs - all passed.
Fixes eclipse-platform#370
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 37ad17d commit 39d028e
File tree
1 file changed
+5
-1
lines changed- tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
| 251 | + | |
250 | 252 | | |
251 | 253 | | |
252 | 254 | | |
253 | 255 | | |
254 | 256 | | |
| 257 | + | |
| 258 | + | |
255 | 259 | | |
256 | 260 | | |
257 | 261 | | |
| |||
0 commit comments