Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats the point of this if the client will have the secret? #1

Open
SupertigerDev opened this issue Jul 17, 2019 · 5 comments
Open

Comments

@SupertigerDev
Copy link

How will this prevent any security issues if the client will still have the secret key?

@laggingreflex
Copy link
Owner

Yeah, you're right. I didn't think this through. Thanks for pointing this out!

@ifree92
Copy link

ifree92 commented Aug 12, 2019

I will use it for personal purposes where the server and client are nodejs side.
The only thing I need - to prevent its easy interception and that's it.

@LosTigeros
Copy link
Contributor

You can always make a function that'll create a key. It won't be that easy to find it for beginners after minifying.

@probil
Copy link

probil commented Apr 24, 2021

You can enforce https and wss (secured) connection through socket.io-client configuration in order to make data encrypted while going through the wire. I don't see a point of this package either.

@laggingreflex
Copy link
Owner

laggingreflex commented Apr 24, 2021

If you're already on https you probably don't need this, I agree.

I remember now, my original use case for this was to use in socket-file-sync where the client was also a server (as opposed to a browser environment) so the secret being "leaked" (via public-facing JS file) wasn't really a concern. And this seemed a lot easier than doing server-to-server https (maintaining keys and everything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants