Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs spotted when going through export #95

Open
kjappelbaum opened this issue Oct 24, 2023 · 4 comments
Open

Bugs spotted when going through export #95

kjappelbaum opened this issue Oct 24, 2023 · 4 comments
Labels
bug Something isn't working priority

Comments

@kjappelbaum
Copy link
Collaborator

kjappelbaum commented Oct 24, 2023

-'Question: What is the count of hexamethylene in the molecule with InChI InChI=1S/C19H28O2/c1-18-9-7-15-14-6-4-13(20)11-12(14)3-5-16(15)17(18)8-10-19(18,2)21/h15-17,21H,3-11H2,1-2H3?\nConstraint: return a list of integers.' returns 57

  • 'Question: What is the count of lauryl in the molecule with InChI InChI=1S/C19H28O2/c1-18-9-7-15-14-6-4-13(20)11-12(14)3-5-16(15)17(18)8-10-19(18,2)21/h15-17,21H,3-11H2,1-2H3?\nConstraint: return a list of integers.' return 48

We need unit tests for the SMARTs they do no work as expected.

@kjappelbaum kjappelbaum added the bug Something isn't working label Oct 24, 2023
@kjappelbaum
Copy link
Collaborator Author

one can use https://smarts.plus/smartsview to check the SMARTS

@Arkhymadhe
Copy link
Collaborator

Arkhymadhe commented Nov 7, 2023

I'll also begin working on this. Then again, we already know that there are issues with Inchi molecules.

@kjappelbaum
Copy link
Collaborator Author

is this still an issue or do we now have tests for that?

@Arkhymadhe
Copy link
Collaborator

is this still an issue or do we now have tests for that?

Haven't had the time to check it out. Will keep this in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

2 participants