-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Program cmp depends on hints_ranges ordering #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
force-pushed
the
fix-program-cmp
branch
from
July 26, 2023 21:21
c803e6b
to
d7c95ad
Compare
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
July 26, 2023 21:23
Codecov Report
@@ Coverage Diff @@
## main #1351 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 93 93
Lines 37852 37853 +1
=======================================
+ Hits 36902 36903 +1
Misses 950 950
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Jul 26, 2023
Benchmark Results for unmodified programs 🚀
|
pefontana
approved these changes
Jul 28, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the comparison of
Program
instances. If the same program was deserialized by two differentcairo-vm
builds, the resultingProgram
s'hints
attributes would differ, even though both had the same functionality.Checklist