Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check as_int calls using to_bigint instead of to_signed_felt in hint implementationss #1190

Closed
fmoletta opened this issue May 30, 2023 · 0 comments · Fixed by #1191
Closed
Labels
bug Something isn't working high-priority

Comments

@fmoletta
Copy link
Contributor

fmoletta commented May 30, 2023

In a previous iteration, the logic of the function as_int was implemented in the felt library under the to_bigint method. Later on, the to_bigint was changed to be just a simple type conversion, and the as_int logic was moved to the to_signed_felt method. Nevertheless, some hints are still using to_bigint when they should be using to_signed_felt (example #1189).
All hints using as_int in their python code should be checked to make sure we using to_signed_felt on their implementation

@fmoletta fmoletta added bug Something isn't working high-priority labels May 30, 2023
@fmoletta fmoletta linked a pull request May 30, 2023 that will close this issue
6 tasks
@marco-paulucci marco-paulucci moved this to In Review in Starknet May 31, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Starknet Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant