Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cairo1] Append returned values to the Output builtin segment #1593

Closed
pefontana opened this issue Jan 30, 2024 · 0 comments · Fixed by #1597
Closed

[Cairo1] Append returned values to the Output builtin segment #1593

pefontana opened this issue Jan 30, 2024 · 0 comments · Fixed by #1597
Assignees
@fmoletta
Labels
cairo1run enhancement New feature or request high-priority

Comments

@pefontana
Copy link
Collaborator

When executing cairo1-run crate with proof mode, we need to add some instructions in the create_entry_code function, that appends the returned values of main to the Output Builtin segment.

For a first iteration, we can assume the return value is just a Felt
@pefontana pefontana added the enhancement New feature or request label Jan 30, 2024
@pefontana pefontana moved this to Todo in Starknet Jan 30, 2024
@fmoletta fmoletta changed the title [Cairo1] Append returned values to the Output builtin [Cairo1] Append returned values to the Output builtin segment Jan 30, 2024
@fmoletta fmoletta self-assigned this Feb 1, 2024
@fmoletta fmoletta moved this from Todo to In Progress in Starknet Feb 1, 2024
@fmoletta fmoletta linked a pull request Feb 1, 2024 that will close this issue
[Cairo1] Append return values to the output segment when running in proof_mode #1597
Merged
@fmoletta fmoletta moved this from In Progress to In Review in Starknet Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Starknet Feb 6, 2024
@fmoletta fmoletta mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmoletta fmoletta

Labels
cairo1run enhancement New feature or request high-priority
Projects
Starknet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cairo1] Append return values to the output segment when running in proof_mode lambdaclass/cairo-vm
2 participants
@pefontana @fmoletta