Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending dynamic layout features #1834

Open
JulianGCalderon opened this issue Sep 4, 2024 · 0 comments
Open

Pending dynamic layout features #1834

JulianGCalderon opened this issue Sep 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JulianGCalderon
Copy link
Contributor

JulianGCalderon commented Sep 4, 2024

Basic dynamic layout support has been implemented in #1824. This issue is to track missing features, and estimate remaining work.

There are a few fields in dynamic layout params that are not being used yet:

  • cpu_component_step: I couldn't find an equivalent for this field in our VM.
  • memory_units_per_step: Right now, this value is taken from the constant MEMORY_UNITS_PER_STEP. Adding field to CairoLayout instead shouldn't take much work.
  • ratio_den: The new builtins can have a ratio smaller than one. Our VM doesn't have support for this yet. My suggestion is to add a method ratio_den() -> Option<usize> to BuiltinRunner, and use that method in get_allocated_instances
  • log_diluted_units_per_step: This field should support negative values. Our VM doesn't have support for this yet. My suggestion is to add a field inverse to DilutedPoolInstanceDef (true if negative) and use it in check_diluted_check_usage to calculate the diluted units.

Also, I found out that a high value of log_diluted_units_per_step (32) hangs our VM. I don't know the cause of this.

@JulianGCalderon JulianGCalderon added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant