[Sierra-Emu] Fix felt-dict's overflow, circuits libfuncs and implement missing EcPoint libfunc (#1208)

* change initial gas due to overflows

* fix some libfuncs in circuits

* fix is() for circuits

* remove Value::Unit from return values in get_output

* match U96LimbsLessThanGuarantee correctly

* some corrections to circuits

* some corrections to circuits

* fix failure_guarantee_verify to avoid panicking

* fix circuits

* more fixes to circuits + implement ec_zero libfunc

* clippy

* remove unnecesary tests

* remove unnecesary file

* fix branch index

* add comment

* fix eval_u96_limbs_less_than_guarantee_verify

* remove circuit failure test

* update trace dump with new Value::CircitOutputs

* fmt

* reviews + fix modulus in trace dump

* remove unnecesary file

* fix clippy

* implement circuit_single_limb_less_than_guarantee_verify

* fix trace dump for circuit outputs

* fix felt_dict_get

* fix felt_dict_get

* implement U96LimbsLessThanGuarantee for trace dump

* remove unnecessary code

* fmt

* fix felt_dict_entry_get

* revert change in circuits.rs

* remove unwanted file

* revert unwanted change

* revert unwanted change

* make trace dump for circuit outputs cleaner

* remove unwanted code

* increase felt dict count always during get()

* doc function + merge main

* reviews

* use elemts stride for offseting u384 structs

* forgot to update one stride

---------

Co-authored-by: Gabriel Bosio <38794644+gabrielbosio@users.noreply.github.com>

Author: FrancoGiachetta

Cargo.lock

@@ -23,6 +23,7 @@ cairo-lang-utils.workspace = true
 clap = { version = "4.5.26", features = ["derive"] }
 k256 = "0.13.4"
 keccak = "0.1.5"
+num-integer.workspace = true
 num-bigint.workspace = true
 num-traits.workspace = true
 p256 = "0.13.2"

debug_utils/sierra-emu/Cargo.toml

@@ -54,6 +54,14 @@ pub fn get_value_from_integer(
         CoreTypeConcrete::Uint32(_) => Value::U32(value.to_u32().unwrap()),
         CoreTypeConcrete::Uint64(_) => Value::U64(value.to_u64().unwrap()),
         CoreTypeConcrete::Uint128(_) => Value::U128(value.to_u128().unwrap()),
+        CoreTypeConcrete::BoundedInt(info) => {
+            let range = &info.range;
+            Value::BoundedInt {
+                range: range.lower.clone()..range.upper.clone(),
+                value,
+            }
+        }
+        CoreTypeConcrete::Felt252(_) => Value::Felt(value.into()),
         _ => panic!("cannot get integer value for a non-integer type"),
     }
 }

debug_utils/sierra-emu/src/utils.rs

@@ -27,8 +27,11 @@ pub enum Value {
         value: BigInt,
     },
     Circuit(Vec<BigUint>),
+    CircuitOutputs {
+        circuits: Vec<BigUint>,
+        modulus: BigUint,
+    },
     CircuitModulus(BigUint),
-    CircuitOutputs(Vec<BigUint>),
     Enum {
         self_ty: ConcreteTypeId,
         index: usize,
@@ -173,25 +176,31 @@ impl Value {
 
             // Circuit related types
             CoreTypeConcrete::Circuit(selector) => match selector {
-                CircuitTypeConcrete::Circuit(_) => matches!(self, Self::Circuit(_)),
-                CircuitTypeConcrete::CircuitData(_) => matches!(self, Self::Circuit(_)),
-                CircuitTypeConcrete::CircuitOutputs(_) => matches!(self, Self::CircuitOutputs(_)),
-                CircuitTypeConcrete::CircuitInput(_) => matches!(self, Self::Unit),
-                CircuitTypeConcrete::CircuitInputAccumulator(_) => matches!(self, Self::Circuit(_)),
+                CircuitTypeConcrete::Circuit(_)
+                | CircuitTypeConcrete::CircuitData(_)
+                | CircuitTypeConcrete::CircuitInputAccumulator(_) => {
+                    matches!(self, Self::Circuit(_))
+                }
+                CircuitTypeConcrete::CircuitOutputs(_) => {
+                    matches!(self, Self::CircuitOutputs { .. })
+                }
                 CircuitTypeConcrete::CircuitModulus(_) => matches!(self, Self::CircuitModulus(_)),
                 CircuitTypeConcrete::U96Guarantee(_) => matches!(self, Self::U128(_)),
-                CircuitTypeConcrete::CircuitDescriptor(_)
-                | CircuitTypeConcrete::CircuitFailureGuarantee(_)
-                | CircuitTypeConcrete::AddMod(_)
+                CircuitTypeConcrete::CircuitInput(_) => {
+                    matches!(self, Self::Struct(_))
+                }
+                CircuitTypeConcrete::U96LimbsLessThanGuarantee(_) => {
+                    matches!(self, Self::Struct(_))
+                }
+                CircuitTypeConcrete::AddMod(_)
                 | CircuitTypeConcrete::MulMod(_)
+                | CircuitTypeConcrete::CircuitDescriptor(_)
+                | CircuitTypeConcrete::CircuitFailureGuarantee(_)
                 | CircuitTypeConcrete::AddModGate(_)
                 | CircuitTypeConcrete::CircuitPartialOutputs(_)
                 | CircuitTypeConcrete::InverseGate(_)
                 | CircuitTypeConcrete::MulModGate(_)
-                | CircuitTypeConcrete::SubModGate(_)
-                | CircuitTypeConcrete::U96LimbsLessThanGuarantee(_) => {
-                    matches!(self, Self::Unit)
-                }
+                | CircuitTypeConcrete::SubModGate(_) => matches!(self, Self::Unit),
             },
             CoreTypeConcrete::Const(info) => self.is(registry, &info.inner_ty),
             CoreTypeConcrete::EcOp(_) => matches!(self, Self::Unit),

debug_utils/sierra-emu/src/value.rs

@@ -36,6 +36,7 @@ fn eval_downcast(
     let [value] = get_numeric_args_as_bigints(&args[1..]).try_into().unwrap();
 
     let int_ty = registry.get_type(&info.to_ty).unwrap();
+
     let range = info.to_range.lower.clone()..info.to_range.upper.clone();
     if range.contains(&value) {
         EvalAction::NormalBranch(