Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(l1): misleading error on apply_fork_choice #1778

Open
fmoletta opened this issue Jan 22, 2025 · 0 comments
Open

bug(l1): misleading error on apply_fork_choice #1778

fmoletta opened this issue Jan 22, 2025 · 0 comments
Labels
bug Something isn't working L1

Comments

@fmoletta
Copy link
Contributor

fmoletta commented Jan 22, 2025 •
edited
Loading

During apply_fork_choice (crates/blockchain/forkchoice) the check_order function is called to check correct ordering between the safe and head block and later on between the finalized and safe block. If the first block is None the check_order function returns Invalid fork choice state. Reason: ElementNotFound(Finalized) which doesn't make sense in the first case.
@fmoletta fmoletta added bug Something isn't working L1 labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working L1
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmoletta