Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Implement deploy for the native syscall handler #1059

Closed
igaray opened this issue Oct 5, 2023 · 0 comments · Fixed by #1106
Closed

Implement deploy for the native syscall handler #1059

igaray opened this issue Oct 5, 2023 · 0 comments · Fixed by #1106
Assignees
@fmoletta
Labels
native

Comments

@igaray
Copy link
Collaborator

igaray commented Oct 5, 2023

The current implementation of the deploy callback in the StarkNetSyscallHandler trait implementation is hardcoded and should instead route to the correct logic to deploy a contract. Cross-reference with the same logic in the virtual machine's syscall handler and emulate.

https://github.com/lambdaclass/starknet_in_rust/pull/943/files#diff-050b376c364b46aa56077588d77a5939973603c9caf47e452bc0895b5b6cd161R75
@igaray igaray added the native label Oct 5, 2023
@igaray igaray added this to Starknet Oct 5, 2023
@fmoletta fmoletta self-assigned this Oct 26, 2023
@fmoletta fmoletta linked a pull request Oct 26, 2023 that will close this issue
Implement NativeSyscallHandler::deploy #1106
Merged
5 tasks
@github-project-automation github-project-automation bot moved this to Done in Starknet Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fmoletta fmoletta

Labels
native
Projects
Starknet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement NativeSyscallHandler::deploy lambdaclass/starknet_in_rust
2 participants
@igaray @fmoletta