Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Correctly price reverted transactions #716

Closed
juanbono opened this issue Jul 3, 2023 · 0 comments · Fixed by #787
Closed

Correctly price reverted transactions #716

juanbono opened this issue Jul 3, 2023 · 0 comments · Fixed by #787
Assignees
Labels
Feature A feature that we need to work on
Milestone

Comments

@juanbono
Copy link
Collaborator

juanbono commented Jul 3, 2023

The fee that will be charged is fee = Min(max_fee, consumed_resources) * configurable_factor when the configurable_factor = 1.
This will ensure that transactions will never pay more than the user signed and only for the actual resources used if possible.

The consumed_resources are the resource used for the execution of the transaction by the point that it failed:

  • Cairo steps, builtins and syscalls in __execute__ until the failure point.
  • Cairo steps, builtins, syscalls, L1 messages, events and state diffs during __validate__
@juanbono juanbono added this to the 0.12.1 milestone Jul 3, 2023
@juanbono juanbono added this to Starknet Jul 3, 2023
@juanbono juanbono moved this to Todo in Starknet Jul 3, 2023
@juanbono juanbono added the Feature A feature that we need to work on label Jul 3, 2023
@matias-gonz matias-gonz self-assigned this Jul 6, 2023
@juanbono juanbono moved this from Todo to In Progress in Starknet Jul 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature A feature that we need to work on
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants