Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1: SimpleCacheDecorator#convertIterableToArray converts float to integer array keys #164

Closed
boesing opened this issue Sep 13, 2021 · 1 comment · Fixed by #165
Closed

PHP 8.1: SimpleCacheDecorator#convertIterableToArray converts float to integer array keys #164

boesing opened this issue Sep 13, 2021 · 1 comment · Fixed by #165
Labels
Bug Something isn't working
Milestone
3.0.0

Comments

@boesing
Copy link
Member

boesing commented Sep 13, 2021

Bug Report

Q A
Version(s) 3.0.0

Summary

In PHP 8.1, keys passed to arrays which are not integer trigger errors.
https://wiki.php.net/rfc/implicit-float-int-deprecate

Current behavior

Implicit conversion from float 1.1 to int loses precision

How to reproduce

TBD

Expected behavior

No error.
@boesing boesing added the Bug Something isn't working label Sep 13, 2021
@boesing boesing added this to the 3.0.0 milestone Sep 13, 2021
@boesing boesing linked a pull request Sep 26, 2021 that will close this issue
Support PHP 8.1 #165
Merged
@boesing
Copy link
Member Author

boesing commented Sep 26, 2021

Closed with #165

@boesing boesing closed this as completed Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Support PHP 8.1 boesing/laminas-cache
1 participant
@boesing