Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of HeaderInterface constants #91

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jun 20, 2020

Fixes nonsense that came after ZF->Laminas transition (what is Laminas value?). Well it was not understandable description already before.

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
*
* @var bool
*/
const FORMAT_ENCODED = true;

/**
* Return value with the interval Laminas value (UTF-8 non-encoded)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "nonsense" was inherited - originally it read "interval ZF2 value". So please, don't blame it on the transition; as they say garbage-in-garbage-out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I git blame'd and it leads to the initial commit.

@weierophinney weierophinney merged commit ce81ab4 into laminas:master Jun 22, 2020
weierophinney added a commit that referenced this pull request Jun 22, 2020
Fix description of HeaderInterface constants
@glensc glensc deleted the ZF2-rename branch June 25, 2020 07:16
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
Fix description of HeaderInterface constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants