Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity check seems buggy at least on classic notebook app #158

Open
falexwolf opened this issue Jul 13, 2022 · 5 comments
Open

Integrity check seems buggy at least on classic notebook app #158

falexwolf opened this issue Jul 13, 2022 · 5 comments

Comments

@falexwolf
Copy link
Member

This is feedback from @paulgb, with a case that we should be able to reproduce:

image

@Koncopd
Copy link
Member

Koncopd commented Jul 13, 2022

Thx, i will check.

@Koncopd
Copy link
Member

Koncopd commented Jul 13, 2022

Now the rule is that the cells are considered run consequently when they start at 1. I can change that ofc, but not sure if i should. I agree that this specific example does't look like it has integrity problem, but the first cell run multiple times can have integrity problems in general.

@falexwolf
Copy link
Member Author

You're right about this, and I also think that starting_at_1 should remain a hard requirement for integrity == 1 to be true.

The problem here is the logging output:
image

It calls out cell transitions as violations that don't seem to be present in the notebook. And it doesn't state that the violation is "Your notebook does not start with cell number 1".

So, there are two things

  1. there might be a bug in computing violations nonetheless
  2. we should have a more specific logging output pertaining to violations of starting_at_1

What do you think, @Koncopd?

@Koncopd
Copy link
Member

Koncopd commented Jul 14, 2022

I am pretty sure this happens because the notebook was not saved before publishing.

@falexwolf
Copy link
Member Author

Could you update the documentation correspondingly, @Koncopd? To state that cells need to start with 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants