Fix #11861 - hash nested calls to inline definitions

[bishabosha]

fixes #11861

[informarte]

Will this fix make it into Scala 3.0.2?

[FabioPinheiro]

@informarte You mean 3.0.3 (3.0.2 was already released)

[bishabosha]

@informarte You mean 3.0.3 (3.0.2 was already released)

next release will be 3.1.0

Will this fix make it into Scala 3.0.2?

Yes, for 3.1.0, I can go back and address the comments - we will see if the implementation is correct

[informarte]

@bishabosha, @smarter, what are your plans for this PR? I see tests, I see a green build, I see comments that were addressed, so what keeps you from merging this fix?

[bishabosha]

what are your plans for this PR?

I just need to add some assertion tests and should be good to go

[SethTisue]

I'm interested in seeing this land, since it would help me in my own compiler hacking. (Happy to help, even, if there's something I can do.)

[bishabosha]

Hey @SethTisue, I will dedicate myself to this tomorrow - mostly the confusion comes from this comment - #12931 (comment) where I got an error from building - seemingly that incremental compilation might still be incorrect - the remaining work then is to add some assertions and maybe experiment to trigger the same error if it was not a fluke

[bishabosha]

@smarter I have changed to implementation to only use apiDefinition, and have adapted apiAnnotations to control the loop condition for inline body hashing

[smarter]

A few comments still but I think we're getting there!

[smarter]

Potential generalization that could be done later: instead of having a hash just for inline params, have a hash for all the potentially pickled flags: if we define a val PickledFlags union of everything that appears in TreePickler#pickleFlags we could do h = mix(h, p.flags & PickledFlags) (though like in tasty pickling we need to be careful about Stable cf 456e7c6)

[smarter]

Otherwise LGTM!

[smarter]

@bishabosha bishabosha added the release-notes label 2 hours ago

I think the convention we used is that if something should be mentioned in the release note, the PR description should be updated with the text to be inserted in the release note, could you handle that?