Fix #12800: Clarify match type reduction error on empty scrutinee #13184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
approved these changes
Jul 28, 2021
| @@ -91,6 +98,9 @@ object MatchTypeTrace: | |||
| | matches none of the cases | |||
| | | |||
| | ${casesText(cases)}""" | |||
| case EmptyScrutinee(scrut) => | |||
| i""" failed since selector $scrut | |||
| | is uninhabited.""" | |||
There was a problem hiding this comment.
Could we explain a bit what uninhabited means? Something like uninhabited (no instance of that type can be constructed)
|
I guess someone else should also take a look at this PR. |
OlivierBlanvillain
force-pushed
the
fix-12800
branch
from
6cafbe9
to
92f5806
Compare
nicolasstucki
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.