-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: display the compiler + Java version on startup #13193
REPL: display the compiler + Java version on startup #13193
Conversation
apologies to @som-snytt for not festooning this with configuration knobs and levers |
I will say that trimming the message was one of my early contributions, IIRC. There was back and forth about what to say in one line that is beginner friendly but not annoying. Now we need Seth's other favorite feature, the prompt with version string. |
😋 |
Co-authored-by: Seth Tisue <seth@tisue.net>
7db844f
to
2b1b622
Compare
in case anyone doubts the value of having a banner and including this information: first, I think it's crucial for beginners to tell them about second, about showing the Scala version and JDK version, one could also imagine having an but by the time a user thinks to run something like then maybe they're filing a bug report or asking for help on Gitter, and do they think to tell us what their Scala and JDK versions are? maybe, but if it's right there in the REPL banner it's a lot likelier they'll do that having it in the banner reminds people that hey, Scala isn't just Scala, it often matters which version you have and what JDK you're running it on and although we certainly don't want creeping banner bloat, I feel like the Scala 2 style banner is sufficiently brief as not to waste space or be annoying I may be a bit biased because I happen to be answer-questions-on-Gitter guy and I'm also triage-people's-bug-reports guy :-) |
I do think adding a |
before:
after:
which brings 3 in line with Scala 2: