-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaladoc: Integrate Scastie into Scaladoc #13258
Scaladoc: Integrate Scastie into Scaladoc #13258
Conversation
004edfa
to
582b389
Compare
582b389
to
cf3315c
Compare
cf3315c
to
f6332a3
Compare
f6332a3
to
18da7b1
Compare
closes #13065 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Two nitpicks/questions:
- Should the resources (like font-awesome) be downloaded (like inkuire.js) or added to the repo as static files?
- Does scastie API allow to change the initial cursor position? IMHO it would be better for it to be at the end.
Hey @pikinier20. I'm really curious about how this |
Hey, yes, there's a setting in Scaladoc: val scastieConfiguration: Setting[String] =
StringSetting("-scastie-configuration", "Scastie configuration", "Additional configuration passed to Scastie in code snippets", "") You can there specify From what I remember, it may be tricky to properly escape quotes. |
also fixes #13275
Release notes template