Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tasty inspector returned value #13316

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

BarkingBad
Copy link
Contributor

@BarkingBad BarkingBad commented Aug 17, 2021

Release notes template

Now TastyInspector.{inspectTastyFiles, inspectTastyFilesInJar, inspectAllTastyFiles} return a boolean value indicating whether the process succeeded

@dwijnand
Copy link
Member

[info] Test dotty.tools.dotc.BootstrappedStdLibTASYyTest.testTastyInspector started
Error:  Test dotty.tools.dotc.BootstrappedStdLibTASYyTest.testTastyInspector failed: java.lang.AssertionError: assertion failed: Errors reported while loading from TASTy, took 5.787 sec
Error:      at scala.runtime.Scala3RunTime$.assertFailed(Scala3RunTime.scala:8)
Error:      at dotty.tools.dotc.BootstrappedStdLibTASYyTest$.loadWithTastyInspector(BootstrappedStdLibTASYyTest.scala:113)
Error:      at dotty.tools.dotc.BootstrappedStdLibTASYyTest.testTastyInspector(BootstrappedStdLibTASYyTest.scala:22)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
Error:      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Error:      at java.lang.reflect.Method.invoke(Method.java:567)
Error:      ...

@nicolasstucki nicolasstucki self-assigned this Aug 23, 2021
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Aug 23, 2021
@nicolasstucki nicolasstucki merged commit ea63740 into scala:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants