Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow experimental erased in experimental scopes #13394

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Allow experimental erased in experimental scopes #13394

merged 1 commit into from
Aug 30, 2021

Conversation

nicolasstucki
Copy link
Contributor

Closes #13392

@nicolasstucki nicolasstucki mentioned this pull request Aug 26, 2021
Closed
@nicolasstucki nicolasstucki force-pushed the allow-erasedDefinitions-import-without-experimental branch 2 times, most recently from c32872f to ea8cb80 Compare August 26, 2021 14:04
@odersky odersky mentioned this pull request Aug 26, 2021
Closed
@nicolasstucki nicolasstucki mentioned this pull request Aug 26, 2021
Merged
@odersky
Copy link
Contributor

odersky commented Aug 26, 2021

If #13396 works it would be preferable.

@nicolasstucki
Copy link
Contributor Author

If #13396 works it would be preferable.

#13396 won't unblock #11721

@nicolasstucki nicolasstucki force-pushed the allow-erasedDefinitions-import-without-experimental branch from ea8cb80 to 8be7635 Compare August 26, 2021 14:56
@odersky
Copy link
Contributor

odersky commented Aug 26, 2021

#13396 won't unblock #11721

Why not?

@nicolasstucki
Copy link
Contributor Author

Ok, it seems #13396 it does unblock #11721. Some bugs confused my understanding of that PR.

@odersky
Copy link
Contributor

odersky commented Aug 27, 2021

I am OK with getting in #13394 and #13396. I believe #13396 is the long term solution that does the right thing for experimental language imports. For instance, it would make it possible to write tests for experimental.fewerBraces without the test framework exception (which I also dislike since it is an exception that is not universally available).

#13394 is still useful as a short term fix to allow experimental erased methods with other methods.

So we could merge both.

@nicolasstucki nicolasstucki force-pushed the allow-erasedDefinitions-import-without-experimental branch from 8be7635 to 961dcb5 Compare August 30, 2021 08:21
@nicolasstucki nicolasstucki marked this pull request as ready for review August 30, 2021 08:23
@nicolasstucki nicolasstucki force-pushed the allow-erasedDefinitions-import-without-experimental branch from 961dcb5 to 791aeb3 Compare August 30, 2021 12:13
@nicolasstucki nicolasstucki merged commit 028c749 into scala:master Aug 30, 2021
@nicolasstucki nicolasstucki deleted the allow-erasedDefinitions-import-without-experimental branch August 30, 2021 13:47
@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Cannot use experimental language features in @experimental code
3 participants
@nicolasstucki @odersky @Kordyjan