Allow experimental language imports in experimental scopes #13417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
allow-experimental-imports-in-experimetnal-scopes
branch
2 times, most recently
from
2d61dd0
to
8e2957e
Compare
nicolasstucki
force-pushed
the
allow-experimental-imports-in-experimetnal-scopes
branch
3 times, most recently
from
5cf6c79
to
c92da2e
Compare
nicolasstucki
force-pushed
the
allow-experimental-imports-in-experimetnal-scopes
branch
2 times, most recently
from
cf1a732
to
1d9e672
Compare
Also allow top-level experimental language imports if all top-level definitions are experimental
nicolasstucki
force-pushed
the
allow-experimental-imports-in-experimetnal-scopes
branch
from
1d9e672
to
3fb1b6d
Compare
|
It is simpler to look at the commits individually, the second only moves documentation. |
nicolasstucki
commented
Aug 31, 2021
| def check(stable: => String) = | ||
| Feature.checkExperimentalFeature("features", imp.srcPos, | ||
| s"\n\nNote: the scope enclosing the import is not considered experimental because it contains the\nnon-experimental $stable") | ||
| if ctx.owner.is(Package) then |
There was a problem hiding this comment.
The main change in this logic is the addition of this condition to detect if we are in a top-level scope.
dwijnand
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version of #13396 that only add the extra rule for top-level experimental imports.