Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggested stub implementation code #13529

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Fix suggested stub implementation code #13529

merged 2 commits into from
Sep 22, 2021

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Sep 14, 2021

Fixes #13076
Fixes #13466

Co-authored-by: Seth Tisue seth@tisue.net

@SethTisue
Copy link
Member

(It bothers me a bit that we pretty much copied/pasted the PolyType handling code from toText, perhaps that could be DRY-ed up, but 🤷, it's probably fine as is, there is already a lot of similar near-duplication.)

@SethTisue
Copy link
Member

SethTisue commented Sep 14, 2021 •
edited
Loading

It was a nice bonus that our changes improved several error messages that aren't even related to unimplemented-abstract-members.

dwijnand
dwijnand approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think asSeenFrom isn't cheap, but I don't know if there's a cheaper variant we can use instead, so LGTM. I don't sweat 3 similar LOC when deduping and abstracting the differences isn't obvious.

griggt and others added 2 commits September 21, 2021 18:18
@griggt @SethTisue
Generate suggested stub methods as seen from implementing class
cca4732 
Fixes scala#13076

Co-authored-by: Seth Tisue <seth@tisue.net>
@griggt @SethTisue
Improve appearance of error messages that include polymorphic method …
a464be3 
…types

Fixes scala#13466

Co-authored-by: Seth Tisue <seth@tisue.net>
@griggt griggt merged commit 321a92c into scala:master Sep 22, 2021
@griggt griggt deleted the fix-13076 branch September 22, 2021 03:01
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
4 participants
@griggt @SethTisue @dwijnand @Kordyjan