Prioritize ambiguous errors in extension method search #13588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an extension method search fails with an ambiguity, report the ambiguous message instead of a message pertaining to the (arbitrary) surviving alternative.
odersky
commented
Sep 22, 2021
| | value id is not a member of testcode.A. | ||
| | An extension method was tried, but could not be fully constructed: | ||
| | | ||
| | testcode.ExtensionA.id(a) failed with |
There was a problem hiding this comment.
It would be nice if we issued
id(a) failed with
instead, but it turns out to be devilishly complicated to do so. So I decided it's not worth going down that rabbit hole since a fix would likely make code that's already super complicated even less understandable.
anatoliykmetyuk
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an extension method search fails with an ambiguity, report the ambiguous message instead
of a message pertaining to the (arbitrary) surviving alternative.
Fixes #13558