Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken lookups #13697

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix broken lookups #13697

merged 1 commit into from
Oct 6, 2021

Conversation

BarkingBad
Copy link
Contributor

This PR fixes:

  • double escaping in links resulting in wrong presentation, e. g: scala.<:<
  • wrong lookups for some links, e. g. [[ <.< ]]

@BarkingBad BarkingBad linked an issue Oct 5, 2021 that may be closed by this pull request
Scaladoc: Wrong escaping of special characters in links #13693
Closed
@BarkingBad
Copy link
Contributor Author

BarkingBad commented Oct 5, 2021 •
edited
Loading

Hey Aleksander, I added you as a reviewer since I observed the misconception in LookUps logic and in unit tests. I think the root problem was package object of scala since LookUpMember yielded module class Scala as an owner for <.< which was breaking the logic of driInContextOfInheritingParent method from SymOps (for handling links to overriden members) and was returning some unresolvable DRI. Could you take a look if the changes seem good?

@BarkingBad
Copy link
Contributor Author

https://scala3doc.virtuslab.com/pr-fix-broken-lookups/scala3/api/scala/=:=.html

abgruszecki
abgruszecki approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BarkingBad BarkingBad merged commit adeb1ab into scala:master Oct 6, 2021
@BarkingBad BarkingBad deleted the scaladoc/fix-broken-lookups branch October 6, 2021 12:25
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

@abgruszecki abgruszecki abgruszecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Scaladoc: Wrong escaping of special characters in links
4 participants
@BarkingBad @abgruszecki @KacperFKorban @Kordyjan