Do not perform completion on higher kinded trees #13700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Oct 6, 2021
Comment on lines
118
to
119
| case Select(qual, _) :: _ if !qual.tpe.hasSimpleKind => Map.empty | ||
| case Select(qual, _) :: _ => completer.selectionCompletions(qual) |
There was a problem hiding this comment.
I would recommend swapping these 2 cases to avoid the unnecessary negation:
Suggested change
| case Select(qual, _) :: _ if !qual.tpe.hasSimpleKind => Map.empty | |
| case Select(qual, _) :: _ => completer.selectionCompletions(qual) | |
| case Select(qual, _) :: _ if qual.tpe.hasSimpleKind => completer.selectionCompletions(qual) | |
| case Select(qual, _) :: _ => Map.empty |
| @@ -169,3 +169,21 @@ class CustomCompletionTests extends DottyTest: | |||
|
|
|||
| assert(offset == prefix.length) | |||
| assert(labels.contains("scala.Function2")) | |||
|
|
|||
| @Test def i12465_hkt(): Unit = | |||
There was a problem hiding this comment.
Move these tests to CompletionTest.scala where they can be written in a much more concise way:
@Test def i12465_hkt: Unit =
code"""???.asInstanceOf[scala.collection.Seq].${m1}""".withSource
.completion(m1, Set())
@Test def i12465_hkt_alias: Unit =
code"""???.asInstanceOf[Seq].${m1}""".withSource
.completion(m1, Set())
prolativ
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution was developed during the 6th issue spree in the collaboration of @ghostbuster91 @KacperFKorban and @mtk.
We followed suggestion from @anatoliykmetyuk that invalid trees as
???.asInstanceOf[Seq]which would result in compilation error when submitted in repl shouldn't provide any completions.Proposed solution behaves consistently both for
???.asInstanceOf[Seq]and???.asInstanceOf[scala.collection.Seq]giving zero completions.This closes #12465