Fix links to unexisting types sites #13917
Conversation
| "-external-mappings:" + | ||
| ".*scala/.*::scaladoc3::https://dotty.epfl.ch/api/," + | ||
| ".*java/.*::javadoc::https://docs.oracle.com/javase/8/docs/api/", | ||
| def scalacOptionsDocSettings(includeExternalMappings: Boolean = true) = { |
There was a problem hiding this comment.
Is this part needed for this fix?
There was a problem hiding this comment.
Yes, because by default we were adding a external mapping to dotty.epfl.ch in Scala documentation. Our mechanism to resolve links tries to match external mapping for symbols that are not present in docs. Since the private API was not present in docs, Scaladoc matched external mapping for it and generated unexisting link
There was a problem hiding this comment.
Isn't it a general problem? I mean, maybe we should not try to match any link for members that are private, not workaround it this way
There was a problem hiding this comment.
That's why I introduced changes with filtering symbols that shouldn't be visible. Maybe we should once more go through whole code that gathers symbols and check if we filter all symbols correctly.
I removed the external link to dotty because it was redundant and should never be there.
pikinier20
force-pushed
the
scaladoc/fix-unexisting-links
branch
from
47d52fc
to
40da3a1
Compare
closes #13867