Support quoted PolyFunction #14222
Merged
Support quoted PolyFunction #14222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jan 6, 2022
| @@ -91,11 +91,6 @@ object PickledQuotes { | |||
| val quotedType = typeHole(idx, reifiedArgs) | |||
| PickledQuotes.quotedTypeToTree(quotedType) | |||
| } | |||
| case tree: Select => | |||
| // Retain selected members | |||
There was a problem hiding this comment.
Happy to see a bug fixed by deleting code, but I don't really understand what this code was there for in the first place 😅. What does retaining means here?
There was a problem hiding this comment.
I do not remember exactly. There was an issue where the selects lost their symbol and this was a workaround. We must have fixed the actual source of the issue in the meantime.
smarter
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14180